Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon does not show an active skin tone #17660

Closed
pomek opened this issue Dec 17, 2024 · 1 comment
Closed

Balloon does not show an active skin tone #17660

pomek opened this issue Dec 17, 2024 · 1 comment
Assignees
@przemyslaw-zan
Labels
package:emoji squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 82 (v44...

Comments

@pomek
Copy link
Member

pomek commented Dec 17, 2024

📝 Provide detailed reproduction steps (if any)

  1. Visit http://localhost:8125/ckeditor5-emoji/tests/manual/emoji.html
  2. Open the emoji balloon.
  3. Change the skin tone.
  4. Open the skin tone again.

✔️ Expected result

An example from the heading demo:

Image

❌ Actual result

Image
@pomek pomek added package:emoji squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior. labels Dec 17, 2024
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Dec 18, 2024
@przemyslaw-zan przemyslaw-zan self-assigned this Dec 19, 2024
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Dec 19, 2024
@przemyslaw-zan przemyslaw-zan mentioned this issue Dec 19, 2024
Merged
przemyslaw-zan added a commit that referenced this issue Dec 20, 2024
@przemyslaw-zan
Merge pull request #17676 from ckeditor/ck/17660
cfdc972 
Internal: Emoji mention will take into account the selected skin tone. Closes #17656.

Internal: Active skin tone in the emoji picker will have checkmark and be selected upon opening the skin tone dropdown. Closes #17660.
@pomek
Copy link
Member Author

pomek commented Dec 20, 2024

Done via #17676.

@pomek pomek closed this as completed Dec 20, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 20, 2024
@CKEditorBot CKEditorBot added this to the upcoming milestone Dec 20, 2024
@CKEditorBot CKEditorBot modified the milestones: upcoming, iteration 82 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
package:emoji squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 82 (v44.2.0)
Development

No branches or pull requests
3 participants
@pomek @CKEditorBot @przemyslaw-zan