Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a link crashes when the selected sentence contains an empty line #16660

Closed
DawidKossowski opened this issue Jul 3, 2024 · 0 comments · Fixed by #16661
Closed

Creating a link crashes when the selected sentence contains an empty line #16660

DawidKossowski opened this issue Jul 3, 2024 · 0 comments · Fixed by #16661
Assignees
@DawidKossowski
Labels
package:link squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 76 (v43...

Comments

@DawidKossowski
Copy link
Contributor

DawidKossowski commented Jul 3, 2024 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open any demo with the Link plugin.
  2. Add an empty line (Shift+Enter).
  3. Select a sentence with the empty line (empty line must be above this sentence).
  4. Click the link button from the toolbar.
  5. Close the link balloon.

✔️ Expected result

The balloon closes without errors.

❌ Actual result

There is an error in the console: TypeError: removeHighlightCallback is not a function and the editor crashes.

Nagranie.z.ekranu.2024-07-2.o.11.31.05.mov

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@DawidKossowski DawidKossowski added type:bug This issue reports a buggy (incorrect) behavior. package:link squad:collaboration Issue to be handled by the Collaboration team. labels Jul 3, 2024
@DawidKossowski DawidKossowski self-assigned this Jul 3, 2024
@DawidKossowski DawidKossowski mentioned this issue Jul 3, 2024
Merged
DawidKossowski added a commit that referenced this issue Jul 4, 2024
@DawidKossowski
Merge pull request #16661 from ckeditor/ck/16660
d5af451 
Fix (link): Creating a link in sentences containing an empty line will no longer cause a crash. Closes #16660.
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 4, 2024
@CKEditorBot CKEditorBot mentioned this issue Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawidKossowski DawidKossowski

Labels
package:link squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 76 (v43.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed the creation of fake markers in a sentence that contains an empty line ckeditor/ckeditor5
2 participants
@DawidKossowski @CKEditorBot