Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The list properties toolbar is overriden by List plugin #16192

Closed
pomek opened this issue Apr 10, 2024 · 0 comments · Fixed by #16243 · 4 remaining pull requests
Closed

The list properties toolbar is overriden by List plugin #16192

pomek opened this issue Apr 10, 2024 · 0 comments · Fixed by #16243 · 4 remaining pull requests
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Apr 10, 2024

📝 Provide detailed reproduction steps (if any)

Create an editor containing the plugins in the exact order: [ ..., ListProperties, List, ... ].

To reproduce the issue, you can use the following manual test.

CloudServices, SourceEditing, List, ListProperties

✔️ Expected result

image

The symbol should be visible.

❌ Actual result

image

The ListUI overrides existing icons. The symbol is not visible.

❓ Possible solution

In the past (#7861), we agreed to override icon toolbars. While it makes sense when handling List => ListProperties, it does not make sense for ListProperties => List.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. package:list labels Apr 10, 2024
@pomek pomek added the squad:core Issue to be handled by the Core team. label Apr 19, 2024
illia-stv added a commit that referenced this issue Apr 24, 2024
…toolbar-is-overriden

Fix (List): Order of List and ListProperties plugins should not affect the appearance of the icon in the toolbar. Closes #16192.
@CKEditorBot CKEditorBot added this to the iteration 74 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment