Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SVG optimization script does not take into account excluded files #14762

Closed
psmyrek opened this issue Aug 7, 2023 · 0 comments · Fixed by #14764
Closed

The SVG optimization script does not take into account excluded files #14762

psmyrek opened this issue Aug 7, 2023 · 0 comments · Fixed by #14764
Assignees
@psmyrek
Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 66 (v39...

Comments

@psmyrek
Copy link
Contributor

psmyrek commented Aug 7, 2023

📝 Provide detailed reproduction steps (if any)

Run yarn clean-up-svg-icons packages/ckeditor5-ui/theme/icons.

✔️ Expected result

The script should not modify packages/ckeditor5-ui/theme/icons/project-logo.svg.

❌ Actual result

The project-logo.svg is optimized and it lost colors.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@psmyrek psmyrek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. labels Aug 7, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 7, 2023
@psmyrek psmyrek self-assigned this Aug 7, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 7, 2023
@psmyrek psmyrek mentioned this issue Aug 7, 2023
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 7, 2023
psmyrek added a commit that referenced this issue Aug 7, 2023
@psmyrek
Merge pull request #14764 from ckeditor/ck/14762
8a0d7b2 
Internal: Rewritten the `clean-up-svg-icons` script from shell script to JavaScript and fixed handling excluded icons. Closes #14762.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 7, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 7, 2023
pomek pushed a commit that referenced this issue Aug 8, 2023
@psmyrek @pomek
Merge pull request #14764 from ckeditor/ck/14762
84e7755 
Internal: Rewritten the `clean-up-svg-icons` script from shell script to JavaScript and fixed handling excluded icons. Closes #14762.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 66 (v39.0.2)
Development

Successfully merging a pull request may close this issue.

Fixed script that cleans up SVG icons to support exclusions properly ckeditor/ckeditor5
2 participants
@CKEditorBot @psmyrek