Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Toolbar doesn't show when you have nested tables #10983

Closed
letdowncrush opened this issue Dec 8, 2021 · 4 comments · Fixed by #15150
Closed

Table Toolbar doesn't show when you have nested tables #10983

letdowncrush opened this issue Dec 8, 2021 · 4 comments · Fixed by #15150
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@letdowncrush
Copy link

letdowncrush commented Dec 8, 2021

Tested this on latest version at: https://ckeditor.com/docs/ckeditor5/latest/features/table.html

The test HTML is below.

We seem to be able to access the toolbar for the top level table and the inner most table but not for the one in the middle.

<figure class="table">
    <table style="background-color:hsl(120, 75%, 60%);">
        <tbody>
            <tr>
                <td>
                    <figure class="table">
                        <table>
                            <tbody>
                                <tr>
                                    <td style="background-color:hsl(0, 0%, 100%);">
                                        <figure class="table">
                                            <table>
                                                <tbody>
                                                    <tr>
                                                        <td style="width:500px;">TEST</td>
                                                        <td style="background-color:hsl(180, 75%, 60%);width:500px;">Here is some text&nbsp;</td>
                                                    </tr>
                                                    <tr>
                                                        <td style="width:500px;">TEST</td>
                                                        <td style="background-color:hsl(180, 75%, 60%);width:500px;">Here is more text</td>
                                                    </tr>
                                                </tbody>
                                            </table>
                                        </figure>
                                    </td>
                                </tr>
                            </tbody>
                        </table>
                    </figure>
                </td>
            </tr>
        </tbody>
    </table>
</figure>
@letdowncrush letdowncrush added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 8, 2021
@FilipTokarski
Copy link
Member

For me it's the most outer table which has no toolbar when selected:

0_table2.mp4

@FilipTokarski FilipTokarski added package:table squad:core Issue to be handled by the Core team. labels Jan 4, 2022
@letdowncrush
Copy link
Author

any ideas if / when you might be able to look at a fix for this?

@jestrick123
Copy link

Hello also looking for an issue to above - would you be able to advise when this might get looked at please.

@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Oct 24, 2022
@Reinmar Reinmar added the domain:ui/ux This issue reports a problem related to UI or UX. label Oct 24, 2022
@Reinmar
Copy link
Member

Reinmar commented Oct 24, 2022

I assume that when a table is selected, it should show just one option: "table properties". All other options do not make sense (col menu, row menu, merge, cell props).

Isn't it enough then to configure config.table.tableToolbar to contain that option? NOTE: There are two configuration options for table toolbars. The one we see on the screencast above is the content toolbar.

It may resolve this issue, although I have a feeling that it needs a more holistic review of the UX around table toolbars in such cases so I'd keep this ticket open

niegowski added a commit that referenced this issue Oct 10, 2023
Fix (table): Table properties should be enabled if a table is selected from the outside. Closes #15040. Closes #15041. Closes #10983.
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants