Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List start/reversed] UI part #10877

Closed
Reinmar opened this issue Nov 22, 2021 · 0 comments · Fixed by #10904
Closed

[List start/reversed] UI part #10877

Reinmar opened this issue Nov 22, 2021 · 0 comments · Fixed by #10904
Assignees
@oleq
Labels
package:list squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 50 (v32...

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 22, 2021 •
edited
Loading

Part of #1032.

Random notes:

  • config.list.styles = [ 'styles', 'startIndex', 'reversed' ];
    • it looks odd due to the "styles" being used twice
  • ListStyle is limiting and we decided already to implement this as a monolith
    • Assume renaming ListStyle to ListProperties (will be finalized in a separate ticket)
    • config.list.properties = { styles: true, startIndex: false, reversed: false }; or a array
      • TODO: CHECK HOW TableProperties are configured. Let's try to be consistent.
    • Which of the properties should be enabled?
      • styles for sure
      • in the document editor everything
      • in other editor types we don't enable
  • "List options" → ???
  • Let's go with collapsible section for additional options

Scope of this task:

  • Implementation MVP (ListPropertiesUI):
    • Input for Start at
    • Our toggle for Reversed (already exists as a component)
    • Collapsible "List options" (the UI component needs to be implemented as part of this job)
    • Configurable by that [list.properties](<http://list.properties>) object
    • Focus management (may not need additional work)
    • Keyboard navigation
@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:list squad:core Issue to be handled by the Core team. labels Nov 22, 2021
@oleq oleq self-assigned this Nov 25, 2021
@oleq oleq mentioned this issue Nov 25, 2021
Merged
@Reinmar Reinmar modified the milestone: iteration 49 Dec 1, 2021
arkflpc added a commit that referenced this issue Dec 16, 2021
@arkflpc
Merge pull request #10904 from ckeditor/ck/10877-list-properties-ui
9be585f 
Feature (list): Implemented the numbered list properties UI. Closes #10877.

Other (ui): `FocusCycler` should skip elements that are invisible to the user (see #10877).

Feature (ui): Introduced the `InputView` class for other inputs such as `InputTextView` to inherit from (see #10877).

Feature (utils): Introduced the `isVisible()` helper to detect whether DOM elements are visible to the user in DOM (see #10877).
@oleq oleq added this to the iteration 50 milestone Dec 17, 2021
@tony tony mentioned this issue Jan 4, 2022
Closed
@oleq oleq mentioned this issue Jan 13, 2022
Merged
niegowski added a commit that referenced this issue Jan 13, 2022
@niegowski
Merge pull request #11101 from ckeditor/ci/1281-pagination-number-input
638ef66 
Feature (ui): Introduced the `InputNumberView` class and the `createLabeledInputNumber()` helper for creating number inputs (see #10877).

Internal (ui, list): Moved `InputNumberView` and `createLabeledInputNumber()` from ckeditor5-list to ckeditor5-ui and made them public. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:list squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 50 (v32.0.0)
Development

Successfully merging a pull request may close this issue.

List properties UI ckeditor/ckeditor5
2 participants
@Reinmar @oleq