-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13949 from ckeditor/ck/11580-removeformat-should-…
…remove-inline-styles Fix (style): Remove Format feature should also remove styles. Closes #11580.
- Loading branch information
Showing
3 changed files
with
147 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /** | ||
| * @license Copyright (c) 2003-2023, CKSource Holding sp. z o.o. All rights reserved. | ||
| * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license | ||
| */ | ||
|
|
||
| /* global document */ | ||
|
|
||
| import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph'; | ||
| import Heading from '@ckeditor/ckeditor5-heading/src/heading'; | ||
| import GeneralHtmlSupport from '@ckeditor/ckeditor5-html-support/src/generalhtmlsupport'; | ||
| import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor'; | ||
| import BlockQuote from '@ckeditor/ckeditor5-block-quote/src/blockquote'; | ||
| import CodeBlock from '@ckeditor/ckeditor5-code-block/src/codeblock'; | ||
| import RemoveFormat from '@ckeditor/ckeditor5-remove-format/src/removeformat'; | ||
| import { setData, getData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model'; | ||
|
|
||
| import Style from '../../src/style'; | ||
|
|
||
| describe( 'Integration with RemoveFormat', () => { | ||
| let editor, editorElement, model; | ||
|
|
||
| beforeEach( async () => { | ||
| editorElement = document.createElement( 'div' ); | ||
| document.body.appendChild( editorElement ); | ||
|
|
||
| editor = await ClassicTestEditor.create( editorElement, { | ||
| plugins: [ | ||
| Paragraph, | ||
| Heading, | ||
| CodeBlock, | ||
| BlockQuote, | ||
| GeneralHtmlSupport, | ||
| Style, | ||
| RemoveFormat | ||
| ], | ||
| style: { | ||
| definitions: [ | ||
| { | ||
| name: 'Marker', | ||
| element: 'span', | ||
| classes: [ 'marker' ] | ||
| }, | ||
| { | ||
| name: 'Typewriter', | ||
| element: 'span', | ||
| classes: [ 'typewriter' ] | ||
| }, | ||
| { | ||
| name: 'Deleted text', | ||
| element: 'span', | ||
| classes: [ 'deleted' ] | ||
| }, | ||
| { | ||
| name: 'Multiple classes', | ||
| element: 'span', | ||
| classes: [ 'class-one', 'class-two' ] | ||
| }, | ||
| { | ||
| name: 'Vibrant code', | ||
| element: 'code', | ||
| classes: [ 'vibrant-code' ] | ||
| } | ||
| ] | ||
| }, | ||
| htmlSupport: { | ||
| allow: [ | ||
| { | ||
| name: /^.*$/, | ||
| styles: true, | ||
| attributes: true, | ||
| classes: true | ||
| } | ||
| ] | ||
| } | ||
| } ); | ||
|
|
||
| model = editor.model; | ||
| } ); | ||
|
|
||
| afterEach( async () => { | ||
| editorElement.remove(); | ||
| await editor.destroy(); | ||
| } ); | ||
|
|
||
| it( 'can remove inline styles', () => { | ||
| setData( | ||
| model, | ||
| '<paragraph>[' + | ||
| '<$text htmlSpan=\'{"classes":["marker"]}\'>aaa</$text>' + | ||
| '<$text htmlSpan=\'{"classes":["deleted"]}\'>bbb</$text>' + | ||
| '<$text htmlSpan=\'{"classes":["typewriter"]}\'>ccc</$text>' + | ||
| ']</paragraph>' | ||
| ); | ||
|
|
||
| editor.execute( 'removeFormat' ); | ||
|
|
||
| expect( getData( model, { withoutSelection: true } ) ).to.equal( | ||
| '<paragraph>aaabbbccc</paragraph>' | ||
| ); | ||
| } ); | ||
| } ); |