Skip to content

Commit

Permalink
Merge pull request #16749 from ckeditor/treat-deps-in-dist-folder-as-…
Browse files Browse the repository at this point in the history
…prod

Fix: Add dependencies used in the new `dist` folder as production `dependencies` instead of `devDependencies`. Related to #16646.

Fix (ckeditor5): Change the path to the types in the `package.json`. See #16684.

Internal: Update `dev-*` packages.
  • Loading branch information
filipsobol authored Jul 22, 2024
2 parents 8466080 + c220d4f commit 9993a2e
Show file tree
Hide file tree
Showing 52 changed files with 247 additions and 235 deletions.
16 changes: 7 additions & 9 deletions .circleci/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ jobs:
when: always
name: Validate manual test directories
command: node scripts/ci/check-manual-tests-directory-structure.js
- run:
when: always
name: Check dependencies
command: yarn run check-dependencies
- run:
when: always
name: Execute ESLint
Expand Down Expand Up @@ -204,14 +200,16 @@ jobs:
- prepare_environment_command
- run:
name: Check if packages are ready to be released
command:
yarn run release:prepare-packages --compile-only --verbose

command: yarn run release:prepare-packages --compile-only --verbose

# Commented out due to a limitation of publint: https://github.com/bluwy/publint/issues/105
# - run:
# name: Lint generated packages
# command:
# yarn run release:lint-packages
# command: yarn run release:lint-packages

- run:
name: Check dependencies
command: yarn run check-dependencies

notify_ci_failure:
machine: true
Expand Down
27 changes: 12 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,18 @@
"@ckeditor/ckeditor5-build-multi-root": "42.0.1",
"@ckeditor/ckeditor5-case-change": "42.0.1",
"@ckeditor/ckeditor5-comments": "42.0.1",
"@ckeditor/ckeditor5-dev-build-tools": "^40.0.0",
"@ckeditor/ckeditor5-dev-bump-year": "^40.0.0",
"@ckeditor/ckeditor5-dev-ci": "^40.0.0",
"@ckeditor/ckeditor5-dev-dependency-checker": "^40.0.0",
"@ckeditor/ckeditor5-dev-docs": "^40.0.0",
"@ckeditor/ckeditor5-dev-release-tools": "^40.0.0",
"@ckeditor/ckeditor5-dev-stale-bot": "^40.0.0",
"@ckeditor/ckeditor5-dev-tests": "^40.0.0",
"@ckeditor/ckeditor5-dev-transifex": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-web-crawler": "^40.0.0",
"@ckeditor/ckeditor5-dev-build-tools": "^41.0.0",
"@ckeditor/ckeditor5-dev-bump-year": "^41.0.0",
"@ckeditor/ckeditor5-dev-ci": "^41.0.0",
"@ckeditor/ckeditor5-dev-dependency-checker": "^41.0.0",
"@ckeditor/ckeditor5-dev-docs": "^41.0.0",
"@ckeditor/ckeditor5-dev-release-tools": "^41.0.0",
"@ckeditor/ckeditor5-dev-stale-bot": "^41.0.0",
"@ckeditor/ckeditor5-dev-tests": "^41.0.0",
"@ckeditor/ckeditor5-dev-transifex": "^41.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-dev-web-crawler": "^41.0.0",
"@ckeditor/ckeditor5-document-outline": "42.0.1",
"@ckeditor/ckeditor5-export-pdf": "42.0.1",
"@ckeditor/ckeditor5-export-word": "42.0.1",
Expand Down Expand Up @@ -219,9 +219,6 @@
],
"**/*.css": [
"stylelint --quiet --allow-empty-input"
],
"**/(*.{js,ts,css}|package.json)": [
"ckeditor5-dev-dependency-checker --quiet"
]
},
"eslintIgnore": [
Expand Down
6 changes: 3 additions & 3 deletions packages/ckeditor5-adapter-ckfinder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-upload": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-basic-styles": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-clipboard": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-heading": "42.0.1",
Expand All @@ -29,7 +30,6 @@
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"@ckeditor/ckeditor5-undo": "42.0.1",
"@ckeditor/ckeditor5-upload": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
6 changes: 4 additions & 2 deletions packages/ckeditor5-alignment/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-block-quote": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
Expand Down
9 changes: 5 additions & 4 deletions packages/ckeditor5-autoformat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,24 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-basic-styles": "42.0.1",
"@ckeditor/ckeditor5-block-quote": "42.0.1",
"@ckeditor/ckeditor5-code-block": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-heading": "42.0.1",
"@ckeditor/ckeditor5-horizontal-line": "42.0.1",
"@ckeditor/ckeditor5-list": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"@ckeditor/ckeditor5-undo": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
Expand Down
5 changes: 3 additions & 2 deletions packages/ckeditor5-autosave/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1",
"lodash-es": "4.17.21"
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-source-editing": "42.0.1",
Expand Down
7 changes: 4 additions & 3 deletions packages/ckeditor5-basic-styles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-essentials": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
Expand Down
10 changes: 6 additions & 4 deletions packages/ckeditor5-block-quote/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,24 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-basic-styles": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-heading": "42.0.1",
"@ckeditor/ckeditor5-image": "42.0.1",
"@ckeditor/ckeditor5-list": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-table": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-typing": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-balloon-block/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-balloon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-classic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-decoupled-document/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-inline/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ckeditor5-build-multi-root/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-translations": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-translations": "^41.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"terser-webpack-plugin": "^4.2.3",
"typescript": "5.0.4",
Expand Down
12 changes: 6 additions & 6 deletions packages/ckeditor5-ckbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,28 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-upload": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1",
"blurhash": "2.0.5",
"lodash-es": "4.17.21"
},
"devDependencies": {
"@ckeditor/ckeditor5-autosave": "42.0.1",
"@ckeditor/ckeditor5-basic-styles": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-clipboard": "42.0.1",
"@ckeditor/ckeditor5-cloud-services": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-essentials": "42.0.1",
"@ckeditor/ckeditor5-heading": "42.0.1",
"@ckeditor/ckeditor5-image": "42.0.1",
"@ckeditor/ckeditor5-link": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-upload": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/ckeditor5-ckfinder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-adapter-ckfinder": "42.0.1",
"@ckeditor/ckeditor5-clipboard": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-image": "42.0.1",
"@ckeditor/ckeditor5-link": "42.0.1",
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/ckeditor5-cloud-services/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1"
},
"devDependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
11 changes: 6 additions & 5 deletions packages/ckeditor5-code-block/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
"type": "module",
"main": "src/index.ts",
"dependencies": {
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-ui": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"ckeditor5": "42.0.1",
"lodash-es": "4.17.21"
},
Expand All @@ -22,11 +27,8 @@
"@ckeditor/ckeditor5-basic-styles": "42.0.1",
"@ckeditor/ckeditor5-block-quote": "42.0.1",
"@ckeditor/ckeditor5-clipboard": "42.0.1",
"@ckeditor/ckeditor5-core": "42.0.1",
"@ckeditor/ckeditor5-dev-utils": "^40.0.0",
"@ckeditor/ckeditor5-dev-utils": "^41.0.0",
"@ckeditor/ckeditor5-editor-classic": "42.0.1",
"@ckeditor/ckeditor5-engine": "42.0.1",
"@ckeditor/ckeditor5-enter": "42.0.1",
"@ckeditor/ckeditor5-html-support": "42.0.1",
"@ckeditor/ckeditor5-image": "42.0.1",
"@ckeditor/ckeditor5-indent": "42.0.1",
Expand All @@ -35,7 +37,6 @@
"@ckeditor/ckeditor5-paragraph": "42.0.1",
"@ckeditor/ckeditor5-theme-lark": "42.0.1",
"@ckeditor/ckeditor5-undo": "42.0.1",
"@ckeditor/ckeditor5-utils": "42.0.1",
"typescript": "5.0.4",
"webpack": "^5.58.1",
"webpack-cli": "^4.9.0"
Expand Down
Loading

0 comments on commit 9993a2e

Please sign in to comment.