This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added default configuration parameter for Config #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Mar 2, 2017
src/config.js
Outdated
|
|
||
| // Set default configuration. | ||
| if ( defaultConfigurations ) { | ||
| this._setObjectToTarget( this._config, defaultConfigurations, true ); |
There was a problem hiding this comment.
Why not define()? It's a role of this method to set the default values.
|
Please add a test for a deeper config objects. |
…as default parameters.
|
Done in 4783f38. |
Reinmar
reviewed
Mar 2, 2017
tests/config.js
Outdated
| first: 1, | ||
| second: 2 | ||
| }, | ||
| 'b.foo.first': 1, |
There was a problem hiding this comment.
Not like this, like:
b: {
foo: {
first: 1
}
}This is supported just by coincident :D
|
You forgot about API docs but I'll add them. R+ for the rest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added default configuration parameter for
Config. Closes ckeditor/ckeditor5#4936.Additional information