Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6110: Change name LabeledView -> LabeledFieldView #547

Merged
merged 13 commits into from
Mar 26, 2020
Merged

I/6110: Change name LabeledView -> LabeledFieldView #547

merged 13 commits into from
Mar 26, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Mar 20, 2020 •
edited
Loading

Suggested merge commit message (convention)

Other: Changed the name of the LabeledView component to the LabeledFieldView. See ckeditor/ckeditor5#6110.

Related PR: ckeditor/ckeditor5-theme-lark#274

--

BREAKING CHANGES:

  • From now the instance of a labeled component's view is available through LabeledFieldView#field. It replaced LabeledView#view.

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
@panr panr added pr:sub and removed pr:sub labels Mar 20, 2020
@panr
Copy link
Contributor Author

panr commented Mar 20, 2020 •
edited
Loading

FYI: CI breaks due to the fact that I used console.warn.

@panr
Copy link
Contributor Author

panr commented Mar 23, 2020 •
edited
Loading

I'm struggling with CI. Tried almost everything... What I'm missing? 🤔
I moved this part of code to related PR — #549

@panr panr mentioned this pull request Mar 23, 2020
Closed
@panr
Revert all changes related to deprecation of the LabeledInputView com…
cc6487b 
…ponent.

The changes will appear in a separate PR.
This was referenced Mar 23, 2020
Closed
Merged
@jodator jodator self-assigned this Mar 24, 2020
jodator
jodator suggested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - keep properties names withing class consistently. As other names are somethingView the #filed should be #fieldView.

src/labeledfieldview/labeledfieldview.js Outdated Show resolved Hide resolved
src/labeledfieldview/labeledfieldview.js Outdated Show resolved Hide resolved
@panr
Copy link
Contributor Author

panr commented Mar 25, 2020

@jodator all done ✅🤞

jodator
jodator approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jodator jodator merged commit 5a7aca7 into master Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Reinmar Reinmar Reinmar left review comments

@jodator jodator jodator approved these changes

Assignees

@jodator jodator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panr @Reinmar @jodator