Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Added support for initializing ViewCollection and BodyCollection items using a constructor #545

Merged
merged 16 commits into from
Apr 6, 2020
Merged

Added support for initializing ViewCollection and BodyCollection items using a constructor #545

merged 16 commits into from
Apr 6, 2020

Commits on Feb 19, 2020

  1. Feature: View collection can now also be initialized though construct… 

    …ion.

Ported changes from ckeditor/ckeditor5-utils#309 (1aac49db1ca9ea914f9fc44f00e295474faf3ed2).

Note this breaks BodyCollection integration, so there's more work to be done.
    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    bfe8744 View commit details
    Browse the repository at this point in the history

  2. Internal: Restored locale support for BodyCollection to work correctly.

    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    8843250 View commit details
    Browse the repository at this point in the history

  3. Internal: Locale instance is required only for BodyCollection - so th… 

    …is is where it is added.

Next commit will remove locale handling from the ViewCollection class.
    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    85da301 View commit details
    Browse the repository at this point in the history

  4. Revert "Internal: Restored locale support for BodyCollection to work … 

    …correctly."

This reverts commit 8843250.
    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d1e4ab7 View commit details
    Browse the repository at this point in the history

  5. Tests: Added unit test coverage for BodyCollection constructor.

    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    bcf5b4f View commit details
    Browse the repository at this point in the history

  6. Internal: Collection now works on iterables.

    @mlewand
    mlewand committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    eafba4e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Merge branch 'master' into i/6194

    @mlewand
    mlewand committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    0e34bef View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Merge branch 'master' into i/6194

    @mlewand
    mlewand committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    8838e08 View commit details
    Browse the repository at this point in the history

  2. Docs: Views can be actually an iterable.

    @mlewand
    mlewand committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    db27824 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Merge branch 'master' into i/6194

    @mlewand
    mlewand committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    ab499c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge remote-tracking branch 'origin/master' into i/6319

    @mlewand
    mlewand committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    de36478 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Merge branch 'master' into i/6319

    @oleq
    oleq committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    016c666 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Merge branch 'master' into i/6319

    @mlewand
    mlewand committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    b20a754 View commit details
    Browse the repository at this point in the history

  2. Docs: Adjusted code snippet for the view#createCollection() method.

    @mlewand
    mlewand committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    e470ac5 View commit details
    Browse the repository at this point in the history

  3. Tests: Added a test ensuring that the BodyCollection constructor is p… 

    …roperly handling preinitialized collection items.
    @mlewand
    mlewand committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    c71c323 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Merge branch 'master' into i/6319

    @oleq
    oleq committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    bd93bd0 View commit details
    Browse the repository at this point in the history