This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Remove selection contents on keydown before composition
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have discovered one issue with the current solution. The thing is it fixes #130, however the composition panel appears in a strange location:
I may try do dig a little bit deeper into this. |
|
It seems that
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: Remove selection contents on
keydownbefore composition. Closes ckeditor/ckeditor5#3080. Closes ckeditor/ckeditor5#3120.BREAKING CHANGE: TODO (changebuffer)
Additional information
See ckeditor/ckeditor5#3080 for more details. Entire flow is described in this https://github.com/ckeditor/ckeditor5-typing/issues/83#issuecomment-398690251. There are two small issues in Chrome and Edge - https://github.com/ckeditor/ckeditor5-typing/issues/83#issuecomment-399046255 related to some different stuff.
Chrome issue will be fixed by https://github.com/ckeditor/ckeditor5-engine/issues/1425 as mentioned in https://github.com/ckeditor/ckeditor5-typing/issues/83#issuecomment-399091785.
Edge issue was reported so we may give it some time - https://github.com/ckeditor/ckeditor5-typing/issues/83#issuecomment-399422265.