Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IME][Chrome][Safari] Spanish accent is not inserted with non-collapsed selection #3120

Closed
f1ames opened this issue May 30, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-typing#158
Closed

[IME][Chrome][Safari] Spanish accent is not inserted with non-collapsed selection #3120

f1ames opened this issue May 30, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-typing#158
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 19

Comments

@f1ames
Copy link
Contributor

f1ames commented May 30, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

CKEditor 5 (v10.0.1)

📋 Steps to reproduce

Extracted from https://github.com/ckeditor/ckeditor5-typing/issues/95#issuecomment-333519559:

  1. Go to https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds/classic-editor.html.
  2. Change the language to spanish.
  3. Select some part of the header and the paragraph.
  4. Press ' few times.

✅ Expected result

Spanish accent is inserted and it is possible to compose an accented character.

❎ Actual result

Text disappears and appears again.

bug_cke5

📃 Other details that might be useful

Happens only in Safari (11.0.3 (13604.5.6)) and Chrome (66.0.3359.181 (Official Build) (64-bit)). In Chrome the effect is the same, but it is not that visible.
@f1ames
Copy link
Contributor Author

f1ames commented Jun 12, 2018

Might be related to #3080.

Reinmar referenced this issue in ckeditor/ckeditor5-typing Jun 28, 2018
@Reinmar
Merge pull request #158 from ckeditor/t/83
ab1b46d 
Fix: Remove selection contents on `keydown` before the composition starts. Closes #83. Closes #150.

BREAKING CHANGE: `@ckeditor/ckeditor5-typing/src/changebuffer.js` was moved to `@ckeditor/ckeditor5-typing/src/utils/changebuffer.js';
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

Remove selection contents on keydown before composition ckeditor/ckeditor5-typing
2 participants
@f1ames @mlewand