This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/6569: Remove array sorting flaws from table code #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Apr 17, 2020
niegowski
approved these changes
Apr 17, 2020
Reinmar
reviewed
Apr 17, 2020
| return getFirstLastIndexesObject( indexes ); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
A couple of documentation issues here. Wording, wrong param name, lack of param name in the @param line, etc. I'm going to fix that on master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Introduce
getColumnIndexes()helper method and properly handle index sorting. Closes ckeditor/ckeditor5#6569. Closes ckeditor/ckeditor5#6544.Additional information
I don't have a good idea for a merge message as this:
getColumnIndexes()helper method.getRownIndexes()bugThe PR is too big but reviews are long :(