Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fixed horizontal alignment of table cell in RTL content. #283

Merged
merged 5 commits into from
Mar 26, 2020
Merged

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Fix: Horizontal alignment of table cell in RTL content. Closes ckeditor/ckeditor5#6371.


Additional information

Justify icon looks odd for RTL languages - probably should be mirrored?

@Reinmar Reinmar self-assigned this Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 25, 2020

Coverage Status

Coverage increased (+0.0001%) to 99.935% when pulling 956eb3e on i/6371 into b905aa5 on master.

@Reinmar Reinmar removed their assignment Mar 25, 2020
@Reinmar
Copy link
Member

Reinmar commented Mar 25, 2020

I tested this manually and I can't see a difference with master. But perhaps I'm not getting what the issue was. Or there's still something wrong. E.g., shouldn't table cells be right aligned (also visually – in the editor) in a newly created cells. In fact, it's also left aligned in the entire editor:

I think that the RTL sample should look more like this:

So it seems that there's something else wrong with the table's RTL manual test itself. Am I right, @oleq?

@oleq oleq self-requested a review March 25, 2020 16:33
@niegowski
Copy link
Contributor Author

@Reinmar it's because content language in manual test for RTL is set to 'en' - https://github.com/ckeditor/ckeditor5-table/blob/master/tests/manual/rtl.js#L19

@oleq
Copy link
Member

oleq commented Mar 26, 2020

...which looks like a forgotten change made for some development purpose. @panr?

@panr
Copy link
Contributor

panr commented Mar 26, 2020

...which looks like a forgotten change made for some development purpose. @panr?

If ui: ar should always correspond with content: ar, then yes, it's a bug here.

@oleq oleq merged commit b6ca42e into master Mar 26, 2020
@oleq oleq deleted the i/6371 branch March 26, 2020 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal alignment of the table cell is broken in RTL content
5 participants