This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/200c: Column insertion and cell merging buttons should work correctly... #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the editor content is right–to–left (RTL). Closes #200.
|
Remember to test this with track changes ... |
|
@scofalik The change is at the UI level. Could this affect TC? |
|
Yeah - I think that this shouldn't affect TC from the model POV (I don't know what happens there on the UI level) |
|
This is what it looks like in LTR now. It shouldn't be a big UI deal when it goes RTL.
|
|
I was afraid that after pressing "insert column left" the column would be inserted on the right or something. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Column insertion and cell merging buttons should work correctly when the editor content is right–to–left (RTL). Closes ckeditor/ckeditor5#3277.