This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5-widget/60: Aligned to the new WidgetToolbarRepository API
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
changed the title
isTableContentSelected() utility with getSelectedTableAncestor() WidgetToolbarRepository API
…ContentSelected()` util with `getSelectedTableWidget()`. Replaced `isTableContentSelected()` with `getTableWidgetAncestor()`.
oleq
force-pushed
the
t/ckeditor5-widget/60
branch
from
cdf242d to
b2e1b46
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Aligned to the new
WidgetToolbarRepositoryAPI. Replaced theisTableWidgetSelected()utility withgetSelectedTableWidget(). ReplacedisTableContentSelected()withgetTableWidgetAncestor()(see ckeditor/ckeditor5#4595).BREAKING CHANGE: The
isTableWidgetSelected()utility has been replaced bygetSelectedTableWidget()and returns an editingViewelement instead ofBoolean.BREAKING CHANGE: The
isTableContentSelected()utility has been replaced bygetTableWidgetAncestor()and returns an editingViewelement instead ofBoolean.This change partially reverts the utility to its functionality before 56adacf. The inner widget discovery is now on the
WidgetToolbarRepositoryside.Part of ckeditor/ckeditor5-widget#64.