This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Align image toolbar to the widget toolbar repository #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Sep 19, 2018
src/tabletoolbar.js
Outdated
| this.listenTo( editor.ui, 'update', () => { | ||
| this._checkIsVisible(); | ||
| widgetToolbarRepository.register( 'table', { | ||
| toolbarItems: editor.config.get( 'table.toolbar' ) || [], |
There was a problem hiding this comment.
It should be called table.tableToolbar.
There was a problem hiding this comment.
I've split this PR into two parts, so we can align to the new API first and then add the new toolbar, add depreciation for table.toolbar and so on.
There was a problem hiding this comment.
But we can do all in one PR if you want
|
I wasn't sure in this and other PRs about tests, but I left them as they were because they check the whole integration pretty well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Aligned
ImageToolbarto the widget toolbar repository. Closes ckeditor/ckeditor5#3226.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.