Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Remove mention attribute from selection when selection is at start of… #78

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jun 28, 2019

… parent block.

Suggested merge commit message (convention)

Fix: Remove mention attribute from selection when selection is at the beginning of a parent block. Closes ckeditor/ckeditor5#4663.


Additional information

  • Quit quick fix - the selection set attribute from a node after if it is placed at the begining of a paragraph:
<p>[]<$text mention={}>@foo</$text>

while in such scenario is not:

<p>bar []<$text mention={}>@foo</$text>

@jodator jodator requested a review from Reinmar June 28, 2019 15:34
src/mentionediting.js Outdated Show resolved Hide resolved
src/mentionediting.js Outdated Show resolved Hide resolved
src/mentionediting.js Outdated Show resolved Hide resolved
@Reinmar Reinmar merged commit 946e762 into master Jul 1, 2019
@Reinmar Reinmar deleted the t/77 branch July 1, 2019 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention is lost if inserting text at the beginning of a line
2 participants