Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention is lost if inserting text at the beginning of a line #4663

Closed
dtychshenko opened this issue Jun 27, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-mention#78
Closed

Mention is lost if inserting text at the beginning of a line #4663

dtychshenko opened this issue Jun 27, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-mention#78
Assignees
@jodator
Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 25

Comments

@dtychshenko
Copy link

If a mention is located at the beginning of a line, typing in front of it breaks the mention. This does not happen if the mention is somewhere in the middle of a line. Here's a visual:

losing-mention

I understand why this happens, but wasn't sure if this is a bug or expected behavior. If this is expected, is there a way to get around it and prevent the mention from breaking?

Thanks!
@Mgsy
Copy link
Member

Mgsy commented Jun 28, 2019 •
edited
Loading

I can confirm this behaviour.

cc @jodator

@jodator jodator self-assigned this Jun 28, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-mention Jul 1, 2019
@Reinmar
Merge pull request #78 from ckeditor/t/77
946e762 
Fix: It should be possible to type before a mention which is at the beginning of a block. Closes #77.
@Reinmar
Copy link
Member

Reinmar commented Jul 1, 2019

I merged the PR. Thanks guys!

@dtychshenko
Copy link
Author

Thank you for such a quick turnaround!

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-mention Oct 9, 2019
@mlewand mlewand added this to the iteration 25 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:mention labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 25
Development

Successfully merging a pull request may close this issue.

Remove mention attribute from selection when selection is at start of… ckeditor/ckeditor5-mention
5 participants
@Reinmar @jodator @dtychshenko @mlewand @Mgsy