Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Editor was crashing if multiple, specific block elements were inside list item in loaded/pasted data #123

Merged
merged 4 commits into from
Feb 25, 2019

Conversation

scofalik
Copy link
Contributor

Suggested merge commit message (convention)

Fix: Editor was crashing if multiple, specific block elements were inside list item in loaded/pasted data. Closes ckeditor/ckeditor5#1572.

@scofalik scofalik requested a review from Reinmar February 25, 2019 10:09
@scofalik
Copy link
Contributor Author

scofalik commented Feb 25, 2019

https://github.com/ckeditor/ckeditor5-paragraph/issues/43 This may be an alternative solution to the problem

@scofalik
Copy link
Contributor Author

Maybe I will elaborate more on it: if we would fix autoparagraphing, maybe we don't need to change lists at all. But OTOH we cannot guarantee that every converter will set modelCursor correctly. So proposed solution is still a little safer than relying on modelCursor.

@Mgsy
Copy link
Member

Mgsy commented Feb 25, 2019

I've spent some time pasting different content, including multiple blocks in a list item, and it looks good to me.

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. It works fine as well. I was not able to crash the editor except by doing something when an image is selected in case of very long content (ckeditor/ckeditor5#1578).

@Reinmar Reinmar merged commit 788eea3 into master Feb 25, 2019
@Reinmar Reinmar deleted the t/ckeditor5/1572 branch February 25, 2019 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants