Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5 engine/1555 #114

Merged
merged 4 commits into from
Nov 1, 2018
Merged

T/ckeditor5 engine/1555 #114

merged 4 commits into from
Nov 1, 2018

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Oct 26, 2018

Suggested merge commit message (convention)

Other: Remove Position, Range, Selection imports from engine/model and engine/view.

BREAKING CHANGE: The modelViewInsertion() converter now returns converter callback and requires model instance as a parameter.
BREAKING CHANGE: The modelViewRemove() converter now returns converter callback and requires model instance as a parameter.
BREAKING CHANGE: The modelViewChangeIndent() converter now returns converter callback and requires model instance as a parameter.
BREAKING CHANGE: The viewToModelPosition() converter now returns converter callback and requires model instance as a parameter.
BREAKING CHANGE: The modelToViewPosition() converter now returns converter callback and requires view instance as a parameter.


Additional information

@coveralls
Copy link

Coverage Status

Coverage decreased (-44.1%) to 55.896% when pulling bc810c9 on t/ckeditor5-engine/1555 into 3d2ea98 on master.

@Reinmar Reinmar merged commit bc810c9 into master Nov 1, 2018
@Reinmar Reinmar deleted the t/ckeditor5-engine/1555 branch November 1, 2018 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants