This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Open link balloon on first click #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this PR fixes the bug only on Chrome. It still occurs in FF and Safari. Also, I found a regression caused by this change: ckeditor/ckeditor5#889. Since we're planning to rewrite the highlight so it adds a class (https://github.com/ckeditor/ckeditor5-link/issues/180) let's not merge this PR. I'd rather live with those two clicks needed to show the balloon rather than other weird behaviours. |
|
I'll leave the branch for a while unless we'll change our minds tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Fixed issue with balloon panel not showing when link is clicked for the first time. Closes ckeditor/ckeditor5#4823.
Additional information
I've removed selection position wrapping inside a link, it was causing problems when typing at the link boundaries. Now filler appear there but we decided that it's enough solution for now.