Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow destroying (detaching) the inspector #42

Closed
Reinmar opened this issue Apr 3, 2019 · 3 comments · Fixed by #46
Closed

Allow destroying (detaching) the inspector #42

Reinmar opened this issue Apr 3, 2019 · 3 comments · Fixed by #46
Assignees
@oleq
Milestone
iteration 27

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 3, 2019

I was trying to check one thing in our manual tests but I realised that the inspector is affecting the results. It'd be good if it was possible (even via console) to kill it.

image
@oleq
Copy link
Member

oleq commented Apr 5, 2019

You don't want to detach it from an editor instance but to kill the application entirely? Am I getting this right?

@Reinmar
Copy link
Member Author

Reinmar commented Apr 8, 2019

Yes, I want to kill it completely, so it stops affecting the JS execution results.

@oleq oleq mentioned this issue Apr 8, 2019
Merged
@oleq oleq self-assigned this Apr 8, 2019
@oleq
Copy link
Member

oleq commented Apr 8, 2019

@Reinmar There you go #46.

@oleq oleq mentioned this issue Jun 14, 2019
Open
@Reinmar Reinmar modified the milestones: next, nice-to-have Sep 16, 2019
ma2ciek added a commit that referenced this issue Sep 20, 2019
@ma2ciek
Merge pull request #46 from ckeditor/t/44
69ad014 
Feature: Allowed attaching the inspector collapsed using a configuration passed to `CKEditorInspector#attach()`. Implemented the `CKEditorInspector#destroy()` method. Unified `CKEditorInspector#attach()` arguments syntax and allowed attaching to multiple instances at a time. Closes #44. Closes #42. Closes #48.

BREAKING CHANGE: The `CKEditorInspector.attach( 'editor-name', editor );` syntax was deprecated and replaced by an object literal `CKEditorInspector.attach( { 'editor-name': editor, ... } );`.
@oleq oleq modified the milestones: nice-to-have, iteration 27 Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
iteration 27
2 participants
@Reinmar @oleq