This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/ckeditor5 engine/1198: Update HeadingOption to be compatible with ConverterDefinition.
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinition interface to ckeditor5-engine.
# Conflicts: # src/headingengine.js # tests/headingcommand.js
jodator
force-pushed
the
t/ckeditor5-engine/1198
branch
from
7520d88 to
3c31685
Compare
jodator
force-pushed
the
t/ckeditor5-engine/1198
branch
from
3c31685 to
0d1cd92
Compare
# Conflicts: # src/headingengine.js # tests/headingcommand.js
|
@Reinmar I've updated the PR to have Schama API changes applied. So it's ready to review. |
|
Changes Unknown when pulling 622b004 on t/ckeditor5-engine/1198 into ** on master**. |
|
Changes Unknown when pulling dc12732 on t/ckeditor5-engine/1198 into ** on master**. |
|
Changes Unknown when pulling dc12732 on t/ckeditor5-engine/1198 into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Enhancement: Add support
ConverterDefinitionin Heading. Closes ckeditor/ckeditor5#2443. Closes ckeditor/ckeditor5#651.BREAKING CHANGE:
config.heading.optionsformat has changed. The validHeadingOptionsyntax is now compatible withConverterDefinition:{ model: 'heading1', view: 'h1', title: 'Heading 1' }.Additional information
HeadingOptionas it "extends"ConverterDefinitionany insights on this will be helpful.