This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/6636: Prefix font styles with the .ck-content class.
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
Apr 21, 2020
There was a problem hiding this comment.
Changes in the guide are necessary https://github.com/ckeditor/ckeditor5-font/blob/i/6636/docs/features/font.md#L97-L111.
Note: You shouldn't use PostCSS syntax there in docs, these are for integrations that may or may not use it.
|
@oleq thanks for pointed it out! Changed. 👍 |
pomek
reviewed
Apr 22, 2020
| .text-tiny { | ||
| font-size: .7em; | ||
| } | ||
| /* The values should be synchronized with the "FONT_SIZE_PRESET_UNITS" object in the "/src/fontsize/utils.js" file. */ |
There was a problem hiding this comment.
This line was removed in 2f33bed and as I can see, it appeared again :D
There was a problem hiding this comment.
If it is unnecessary, please get rid of it on master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Font size styles should be prefixed by the
.ck-contentclass. Closes ckeditor/ckeditor5#6636.