This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/984: Don't return the block in which selection ends if it ends at its beginning #985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: The
Selection#getSelectedBlocks()
method will not return a block in which selection ends if no content of that block is selected. Closes ckeditor/ckeditor5#4091.For example, in the following case only the first two paragraphs will be returned:
The reasoning behind this change is that the user doesn't consider the last block as selected in such a case (as its selection isn't even visible).
Additional information
Related branches:
I'm not 100% sure that this change isn't too broad, but let's see based on users' feedback. It's simple so we can tune it up.