This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Correct moving selection during invalid copy-paste #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Jun 5, 2019
| @@ -562,7 +562,7 @@ class Insertion { | |||
|
|
|||
| // Special case – parent is empty (<p>^</p>). | |||
| // We can remove the element after moving insertion position out of it. | |||
| if ( parent.isEmpty ) { | |||
| if ( parent.isEmpty && parent.parent === allowedIn ) { | |||
There was a problem hiding this comment.
Please add an explanation about parent.parent == allowedIn
tests/model/utils/insertcontent.js
Outdated
| @@ -1254,6 +1254,43 @@ describe( 'DataController utils', () => { | |||
| expect( getData( model ) ).to.equal( '<limit>ab[]foo</limit>' ); | |||
| expect( stringify( root, affectedRange ) ).to.equal( '<limit>[ab]foo</limit>' ); | |||
| } ); | |||
|
|
|||
| describe( 'when allowed elements is somewhere above limit', () => { | |||
There was a problem hiding this comment.
I'd go with: 'when allowed element is above limit element in document tree'.
jodator
approved these changes
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Moving selection during forbidden copy-paste operation (pasting table into empty table cell). Closes ckeditor/ckeditor5#1380.