This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
All content is properly removed after undoing paste in some scenarios #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
commented
Feb 18, 2019
| // If the target is the end of the move range this operation doesn't really move anything. | ||
| // In this case, it is better for OT to use range start instead of range end. | ||
| targetPosition.isEqual( range.end ) ? range.start : targetPosition, | ||
| targetPosition, |
There was a problem hiding this comment.
I assume that maybe at some point it was important to change the target position, but then we might have added some cases and this got fixed in a different place. It didn't cause any test to fail and in this scenario, it looked like an obvious error (to use range.start instead of targetPosition).
|
It seems that somewhere along the way (not with this fix) we also fixed "by accident" two of tests that were skipped 🎉. I unskipped them and added them to this PR. |
|
Ugh, you already merged it but there is a coverage drop (one branch) after the changes I've introduced. I will fix it straight on master then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: All content is properly removed after undoing paste in some scenarios. Closes ckeditor/ckeditor5#1540.