This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Always update attributes of reused elements while rendering #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Oct 2, 2018
src/view/renderer.js
Outdated
| // to the DOM, so we need to mark it here to make sure its attributes gets updated. See #1427 for more | ||
| // detailed case study. | ||
| // Also there are cases where replaced element can be removed from view structure and then has | ||
| // its attributes changed. In such cases it si not present in `markedAttributes` and may be the same |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Always update attributes of reused elements while rendering. Closes ckeditor/ckeditor5#4430.
Additional information
See https://github.com/ckeditor/ckeditor5-engine/issues/1560#issuecomment-426218452.
The elements reusing during rendering was implemented mainly to prevent breaking composition. I have checked (with https://codepen.io/f1ames/pen/PyPExr) if updating attributes of the element in which composition takes place can influence composition in any negative way, but it seems to be working fine for such cases.