Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

downcastAttributeToElement should let specify from what element the model attribute will be converted #1373

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Mar 20, 2018

Suggested merge commit message (convention)

Fixed: conversion.downcast-converters.downcastAttributeToElement should let specify from what element the model attribute will be converted. Closes ckeditor/ckeditor5#4321.

@scofalik scofalik requested a review from pjasiun March 20, 2018 13:23
…ould let specify from what element the model attribute will be converted.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cfe14cf on t/1370 into cb03a60 on master.

@pjasiun pjasiun removed their request for review March 20, 2018 14:21
@jodator jodator self-requested a review March 21, 2018 08:26
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@jodator jodator merged commit f8dec1e into master Mar 21, 2018
@jodator jodator deleted the t/1370 branch March 21, 2018 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downcastAttributeToElement does not support downcasting from specified model element
3 participants