This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Merged
View refactoring #1296
Changes from all commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
eb76e20
Changed wirter utility functions to class methods.
szymonkups 5639b6a
Fixed view writer tests.
szymonkups 868d2aa
Initial view controller skeleton.
szymonkups 5223afc
Moving responsibilites from view document to view controller.
szymonkups cde89ab
Merge branch 'master' into t/1210
szymonkups b53613f
Moved all DOM related functionality from view document to view contro…
szymonkups 73677b6
More things moved from view document to view controller. Added event.
szymonkups a3cb217
Cleaned tests of view document.
szymonkups 2b36519
Refactored observers' tests.
szymonkups 3735a66
Fixed view controller tests.
szymonkups de945bb
Fixed tests with placeholder.
szymonkups ebe4922
Fixed view Position test.
szymonkups e8c7f75
Fixed view Selection test.
szymonkups 1025f01
Fixed view TreeWalker test.
szymonkups c8dee0c
Fixed conversion tests.
szymonkups eb3290d
Fixed dev utils tests.
szymonkups e7f0ba9
Controller fixes.
szymonkups 19af78b
Adjusting ticket test to changes in view.
szymonkups 29a2e0a
Merge branch 'master' into t/1210
szymonkups 25b9f6b
Merge branch 'master' into t/1210
szymonkups 8eb46b1
Passing view writer with conversion API.
szymonkups 6de4eff
Removed view and change() block from ModelConversionDispatcher. Now w…
szymonkups c4d1a6c
Merge branch 'master' into t/1210
szymonkups 7eaa1ba
Moving model to view selection conversion into view.change block.
szymonkups 0e04c07
Merge branch 'master' into t/1210
szymonkups 1737084
Changed view utils methods to accept view instance instead of view do…
szymonkups 5d9fcc5
Fixed docs after view controller creation.
szymonkups 1aab5c8
Added creator methods to view writer.
szymonkups 1ceb15f
Added view instance to writer. Fixed placeholder update listener.
szymonkups cfddbb1
Added one more test to placeholder.
szymonkups a78fe24
Added empty view writer test file.
szymonkups 767bf2c
Merge branch 'master' into t/1210
szymonkups 6d622c7
Moved view selection method access to view writer.
szymonkups b8c2bde
Fixed tests after view selection methods visibility change.
szymonkups 142775f
Changed view selection setFake method as protected. Created view writ…
szymonkups f427bb2
Removed view selection from conversionApi, it can be accessed by writ…
szymonkups f91150e
Removed view selection parameter from view writer.wrap() method.
szymonkups 9662257
Using view.change in dev-utils tests instead of modifing selection di…
szymonkups 69f154f
Using view.change in placeholder tests instead of modifing selection …
szymonkups f5b9b68
Updated fake selection manual test to work with view changes.
szymonkups 72356b4
Using view.change in focusobserver tests instead of modifing selectio…
szymonkups 9feacdf
Using view.change in mutationobserver tests instead of modifing selec…
szymonkups 9435e48
Using view.change in selectionobserver tests instead of modifing sele…
szymonkups 8a00bcb
More test updated to use view writer.change() block.
szymonkups 4ed39d2
Using writer to set fake selection in model selection to view convert…
szymonkups 7269c08
Merge branch 'master' into t/1210
szymonkups ec7db7d
Merge branch 'master' into t/1210
szymonkups 4b9e98c
Merge branch 'master' into t/1210
szymonkups 9de3ace
Align manual tests to latest changes in the view.
szymonkups 44580b5
Using setData in manual tests.
szymonkups 80d346a
Using correct initialization on iframe manual test.
szymonkups cbe9a51
Changed EditableElement test to check if selection changes affects it…
szymonkups ae4b9a9
Added docs and tests to engine view controller.
szymonkups b1f8d21
Fixed docs.
szymonkups 21f0dba
Merge branch 'master' into t/1210
szymonkups 1d81921
Merge branch 'master' into t/1210
szymonkups 2fd9058
Removed empty file.
szymonkups cacae9f
Updated documentation.
szymonkups deac6a1
Improved view writer's code coverage.
szymonkups 3f9b87a
Removed default params from view writer.setFakeSelection() method.
szymonkups ad06c37
Merge branch 'master' into t/1210
szymonkups b962a48
Small docs fixes.
szymonkups 7ec6f8a
Merge branch 'master' into t/1210
szymonkups 199be4a
More fixes to tests after changes in the view.
szymonkups 181f113
Updated downcast converters to use view writer where possible.
szymonkups fa87b53
More downcast conversion changes connected to view refactoring.
szymonkups b361fd6
Passing all conversion parameters to creator from array confing.
szymonkups 1e46743
Fixed typos.
szymonkups 983ce9b
Unified usage of view.Writer in converters.
szymonkups 75d1d07
Fixed docs in view.Writer.
szymonkups 85ae406
Removed unused view selection from writer.wrap(). call.
szymonkups b4e5273
Removed writer.createElement() method.
szymonkups 3a546da
Using writer to set attribute on view element.
szymonkups 85c3400
Using writer to remove attribute from view element.
szymonkups ad65a63
Using writer to set class on view element.
szymonkups d1d022c
Using writer to remove class from view element.
szymonkups 8c8a4c5
Using writer to set styles to view element.
szymonkups c4c4d3d
Using writer to remove styles from view element.
szymonkups 4041eb0
Using writer to set custom properties to view element.
szymonkups 01ce914
Using writer to remove custom properties from view element.
szymonkups cefdba4
AttributeElement priority is now protected. EditableElement document …
szymonkups d4fe28f
View writer.createUIElement() method can now initialize rendering met…
szymonkups 833b81f
Updated view writer's docs.
szymonkups 3f110de
Added tests to new methods in view writer.
szymonkups 5b1a8bd
Updated placeholder to use view writer to manipulate view nodes.
szymonkups 7d321b7
Using writer in highlight manual test.
szymonkups 2b923bb
Removed view.jsdoc file.
szymonkups a576a0a
Get rid of view.document#change event and rednerer#render events. Cre…
szymonkups 6242b77
Added comment do DataController why we use view writer without change…
szymonkups d4a8844
Some docs changes in view writer.
szymonkups ce0cca4
Moved model.change() block out of upcast dispatcher.
szymonkups 9d11c64
Docs: View class overview. [skip ci]
27c7906
Get rid of model parameter from downcast dispatcher.
szymonkups f63f2a1
Passing writer to highlight methods.
szymonkups 226a96a
Merge branch 'master' into t/1210
szymonkups b1580a0
Updated highlighting manual test.
szymonkups 4b33b87
Fixed nested editable manual test.
szymonkups 5ac0d62
Updated manual test for ckeditor5-721.
szymonkups b119088
Updated fake selection manual test.
szymonkups 61edf03
Updated UIElement manual test.
szymonkups 47371da
Fixed docs.
szymonkups 08eb9c9
Removed unneeded code.
8a07e76
Docs: use proper writer methods.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make it symmetrical. Since
downcastDispatcher
do not haveview
as a property andchange
is called outside,upcastDispatcher
may have nomodel
and also getwriter
as a parameter.