Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Content-Type" header to .po files for consistent UTF-8 encoding #913

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

pereorga
Copy link
Contributor

@pereorga pereorga commented Aug 16, 2023

This adds the "Content-Type" header to the generated .po files. By explicitly specifying the charset as UTF-8, we ensure consistent interpretation of non-ASCII characters across systems. This addition enhances the portability of the generated Gettext files.

Additional information

Try running Gettext tools such as msgcat or msgattrib on the existing files (e.g. https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-autosave/lang/translations/ca.po)

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek
Copy link
Member

pomek commented Aug 18, 2023

Thanks, @pereorga, for preparing the PR.

@pomek pomek merged commit b0fe2a5 into ckeditor:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants