Fix paths in webpack-plugin for Windows environment #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2ciek
changed the title
ma2ciek
changed the title
|
Are we able to provide at least single test for a Windows and Unix paths? |
|
Do you mean unit tests? I can export those function with an underscore and test them whether their Regexps are correct. |
|
Should be fine. |
|
I added tests for the RegExps only as these are the most vulnerable places for that PR. Whole functions are Webpack-dependent and shouldn't be tested by unit tests IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Fixed paths in webpack-plugin for Windows environment. Closes #297.