-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate demos with external plugins to new installation methods #40
Conversation
18e6ae2
to
88a523b
Compare
cfbf7d4
to
7b7dbd9
Compare
88a523b
to
c4d95b3
Compare
feature-rich/index.ts
Outdated
'selectAll', | ||
'wproofreader', | ||
'|', | ||
// 'insertTemplate', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tripped on this. I provided the license key, as it asked me to, but then surprise, surprise: those premium buttons weren't there. I had quite a big WTH moment :D
The good thing about our toolbar initialization is that even if you used a button that wasn't registered, the editor will work and you will get a warning.
So it's not necessary to comment out missing buttons. And it's definitely confusing :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 👍 I'll fix it - unless you already did 👀
Co-authored-by: Piotr Szczęśniak <[email protected]>
It was a part of this task as we initially discussed with @Witoso and @arkflpc. But I don't know if there is a longer story behind this, maybe they can give more context.
Yeah, I pushed it before the CSS file names changes, also @pszczesniak pointed that out in the first PR - #38 (review). I see you already updated it 🙇 👍
@Reinmar maybe let me know what you are working on here, and how cna I help so we don't duplicate the work. |
…ted paths to CSS files.
…uld not be mixed together with visual styles.
96e56a0
to
7461409
Compare
Ready for review. The only thing missing is enabling MathType and WProofReader in couple of demos, but this needs to wait for NIM compatible versions of those plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ready to merge, but I suggest to wait till MathType and WProofReader are bumped to NIM compatible versions? |
@f1ames i've tested |
This PR migrates demos with 3rd-party plugins to NIM. Follow-up of #38:
It's based on
new-installation-methods-v2
branch (#38 PR) and I followed all the same conventions and assumptions. You can read #38 description for all details.The main difference here is that 3rd-party plugins (WProofreader and Mathtype) are commented out in CKEditor 5 plugins list in it's config in each demo. This way demos can be run and after plugins are migrated to NIM, it should be enough to just uncomment those lines.