This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5/416d: Created a "three vertical dots" icon #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkonopka
reviewed
Sep 18, 2019
theme/icons/three-vertical-dots.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg width="10" height="20" xmlns="http://www.w3.org/2000/svg"><g><circle cx="9.5" cy="4.5" r="1.5"/><circle cx="9.5" cy="10.5" r="1.5"/><circle cx="9.5" cy="16.5" r="1.5"/></g></svg> | |||
There was a problem hiding this comment.
We are not using width/height property for icons, let's change it to the viewBox (with 0 0 20 20).
Also, I would take into consideration to transform svg content to <path> instead a group of <circle>:
There was a problem hiding this comment.
Is path any better than circle @dkonopka?
There was a problem hiding this comment.
I was thinking about the smaller weight of .svg file, but I'm not so sure.
oleq
commented
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Created a "three vertical dots" icon for the toolbar grouping feature (see ckeditor/ckeditor5#416).
Additional information
Part of ckeditor/ckeditor5-ui#523.