This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/107: A test util for checking multi assertions for different browsers #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not quite sure about the name: |
szymonkups
reviewed
Nov 15, 2017
tests/_utils/utils.js
Outdated
| * testUtils.checkAssertions( assertEdge, assertAll ); | ||
| * } ); | ||
| * | ||
| * @param {Array.<Function>} assertions Functions that will be executed. |
There was a problem hiding this comment.
Not an array with functions. It should be documented as {...Function}.
ma2ciek
reviewed
Nov 15, 2017
tests/_utils-tests/utils.js
Outdated
| testUtils.createSinonSandbox(); | ||
|
|
||
| describe( 'utils', () => { | ||
| describe( 'checkAssertions', () => { |
ma2ciek
pushed a commit
that referenced
this pull request
Nov 28, 2017
Tests: Added a new test util `checkAssertions()`. It executes specified assertions and throws only when all assertions fail . Closes #107.
ma2ciek
pushed a commit
that referenced
this pull request
Nov 28, 2017
Tests: Added a new test util `checkAssertions()`. It executes specified assertions and throws only when all assertions fail . Closes #107.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Added a new util which executes specified assertions. Closes ckeditor/ckeditor5#2927.