Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Tests: Added tests for ckeditor/ckeditor5#477.
Browse files Browse the repository at this point in the history
  • Loading branch information
Reinmar committed Jun 23, 2017
1 parent 0016cb2 commit 39a6db7
Show file tree
Hide file tree
Showing 2 changed files with 134 additions and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"devDependencies": {
"@ckeditor/ckeditor5-dev-lint": "^3.1.0",
"@ckeditor/ckeditor5-basic-styles": "^0.8.1",
"@ckeditor/ckeditor5-block-quote": "^0.1.1",
"@ckeditor/ckeditor5-editor-classic": "^0.7.3",
"@ckeditor/ckeditor5-paragraph": "^0.8.0",
"@ckeditor/ckeditor5-enter": "^0.9.1",
Expand Down
133 changes: 133 additions & 0 deletions tests/pasting-integration.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
/**
* @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
* For licensing, see LICENSE.md.
*/

/* globals document */

import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor';
import Clipboard from '../src/clipboard';
import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
import BlockQuote from '@ckeditor/ckeditor5-block-quote/src/blockquote';
import Bold from '@ckeditor/ckeditor5-basic-styles/src/bold';
import Italic from '@ckeditor/ckeditor5-basic-styles/src/italic';
import Link from '@ckeditor/ckeditor5-link/src/link';

import { setData, getData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';

describe( 'Pasting – integration', () => {
let element;

beforeEach( () => {
element = document.createElement( 'div' );

document.body.appendChild( element );
} );

afterEach( () => {
element.remove();
} );

describe( 'inline styles', () => {
// See https://github.com/ckeditor/ckeditor5/issues/477.
it( 'pastes inline styles and links (no block)', () => {
return ClassicTestEditor
.create( element, { plugins: [ Clipboard, Paragraph, Bold, Italic, Link ] } )
.then( editor => {
setData( editor.document, '<paragraph>[]</paragraph>' );

pasteHtml( editor, 'x <strong>bold</strong> <i>italic</i> <a href="x">link</a> y' );

expect( getData( editor.document ) ).to.equal(
'<paragraph>' +
'x <$text bold="true">bold</$text> <$text italic="true">italic</$text> ' +
'<$text linkHref="x">link</$text> y[]' +
'</paragraph>'
);

return editor.destroy();
} );
} );

it( 'pastes inline styles and links (inside known block)', () => {
return ClassicTestEditor
.create( element, { plugins: [ Clipboard, Paragraph, Bold, Italic, Link ] } )
.then( editor => {
setData( editor.document, '<paragraph>[]</paragraph>' );

pasteHtml( editor, '<p>x <strong>bold</strong> <i>italic</i> <a href="x">link</a> y</p>' );

expect( getData( editor.document ) ).to.equal(
'<paragraph>' +
'x <$text bold="true">bold</$text> <$text italic="true">italic</$text> ' +
'<$text linkHref="x">link</$text> y[]' +
'</paragraph>'
);

return editor.destroy();
} );
} );

it( 'pastes inline styles and links (inside unknown block)', () => {
return ClassicTestEditor
.create( element, { plugins: [ Clipboard, Paragraph, Bold, Italic, Link ] } )
.then( editor => {
setData( editor.document, '<paragraph>[]</paragraph>' );

pasteHtml( editor, '<div>x <strong>bold</strong> <i>italic</i> <a href="x">link</a> y</div>' );

expect( getData( editor.document ) ).to.equal(
'<paragraph>' +
'x <$text bold="true">bold</$text> <$text italic="true">italic</$text> ' +
'<$text linkHref="x">link</$text> y[]' +
'</paragraph>'
);

return editor.destroy();
} );
} );

it( 'pastes inline styles and links (inside known block but on disallowed position)', () => {
return ClassicTestEditor
.create( element, { plugins: [ Clipboard, Paragraph, BlockQuote, Bold, Italic, Link ] } )
.then( editor => {
setData( editor.document, '<paragraph>[]</paragraph>' );

pasteHtml( editor, '<blockquote>x <strong>bold</strong> <i>italic</i> <a href="x">link</a> y</blockquote>' );

expect( getData( editor.document ) ).to.equal(
'<blockQuote><paragraph>x bold italic link y[]</paragraph></blockQuote>'
);

// The expected result would be this:
//
// '<blockQuote>' +
// '<paragraph>' +
// 'x <$text bold="true">bold</$text> <$text italic="true">italic</$text> ' +
// '<$text linkHref="x">link</$text> y[]' +
// '</paragraph>' +
// '</blockQuote>'
//
// See https://github.com/ckeditor/ckeditor5/issues/477#issuecomment-310428963.
// Although, this may be a deeper problem with ckeditor5-paragraph's wildcard conversion.

return editor.destroy();
} );
} );
} );
} );

function pasteHtml( editor, html ) {
editor.editing.view.fire( 'paste', {
dataTransfer: createDataTransfer( { 'text/html': html } ),
preventDefault() {}
} );
}

function createDataTransfer( data ) {
return {
getData( type ) {
return data[ type ];
}
};
}

0 comments on commit 39a6db7

Please sign in to comment.