Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility with latest Angular (v11) #235

Closed
pomek opened this issue Dec 7, 2020 · 4 comments · Fixed by #236
Closed

Check compatibility with latest Angular (v11) #235

pomek opened this issue Dec 7, 2020 · 4 comments · Fixed by #236
Assignees
Labels
squad:integrations type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@pomek
Copy link
Member

pomek commented Dec 7, 2020

A similar to CKEditor 4 (ckeditor/ckeditor4-angular#148).

@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:integrations labels Dec 7, 2020
@pomek pomek added this to the iteration 39 milestone Dec 7, 2020
@pomek
Copy link
Member Author

pomek commented Dec 7, 2020

Blindly estimating as 0.5 in case if changes in docs will be required.

@pkwasnik pkwasnik mentioned this issue Dec 10, 2020
@pkwasnik
Copy link
Contributor

pkwasnik commented Dec 10, 2020

There are two issues with zone.js (possibly not blocking the upgrade):

@ma2ciek
Copy link
Contributor

ma2ciek commented Dec 11, 2020

I've checked and the Zone.js 0.11 breaking changes are described here - https://github.com/angular/angular/tree/master/packages/zone.js#breaking-changes-since-zonejs-v0111.

Anyway, could you create an issue in Zone.js for the found regression and link it here?

@ma2ciek
Copy link
Contributor

ma2ciek commented Dec 11, 2020

So, to finish this task we need to:

  • report the regression to the Angular (zone.js) team,
  • document this common issue and a workaround in docs

Apart from that the code in the PR looks good and is ready to merge 👍

ma2ciek added a commit that referenced this issue Dec 21, 2020
Other: Added support for Angular 11. Internal: Updated internal Angular deps to v. 11. Closes #235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:integrations type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants