Paste from word now respect enter_br mode #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
Aug 24, 2017
| @@ -0,0 +1,4 @@ | |||
| <p class=MsoNormal><b style='mso-bidi-font-weight:normal'><i style='mso-bidi-font-style:normal'>Paste from word<br> | |||
There was a problem hiding this comment.
I'm not sure if it's correct fixture for Firefox. It should like like the one from Chrome, containing all HTML as Firefox also supports fetching HTML from native dataTransfer.
| @bender-ckeditor-plugins: pastefromword,toolbar,basicstyles,wysiwygarea,sourcearea | ||
|
|
||
| ---- | ||
| 1. Open [docx file](https://github.com/ckeditor/ckeditor-dev/blob/master/tests/plugins/pastefromword/generated/_fixtures/Enter_BR/Enter_BR.docx) in Microsft Word. |
There was a problem hiding this comment.
It's better to use relative path as this one is not working currently.
| 1. Copy text from file and paste it to editor. | ||
| 1. Check Source in editor. | ||
|
|
||
| **Expected:** There is no `<p>` tags in source. Every pparagraph is replaced wit `<br />`. |
Comandeer
approved these changes
Aug 24, 2017
Comandeer
requested changes
Aug 24, 2017
Comandeer
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
yes
This PR contains
What changes did you make?
Close: #423