Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing tests tests/plugins/justify/justify n Firefox #2369

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Conversation

engineering-this
Copy link
Contributor

What is the purpose of this pull request?

Fix to failing tests

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Assertions are now called asynchronously.

Closes #2349

@Comandeer Comandeer self-requested a review September 3, 2018 11:28
@Comandeer Comandeer self-assigned this Sep 3, 2018
@Comandeer Comandeer self-assigned this Sep 3, 2018
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants