Balloon Toolbar should prefer bottom position #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
force-pushed
the
t/933-3222
branch
from
69c61fb to
9395511
Compare
mlewand
pushed a commit
that referenced
this pull request
Nov 29, 2017
Balloon Toolbar should prefer bottom position
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature
This PR contains
What changes did you make?
The toolbar should prefer bottom position. Reason for that is that on mobile, native context menu (e.g. in case of a ranged selection) is displayed on top (mobile chrome, ios safari, chrome on Windows).
Having our toolbar on the bottom of selection will allow user to use native and our toolbar as well.