Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tool method for array "every" #1075

Merged
merged 3 commits into from
Oct 23, 2017
Merged

New tool method for array "every" #1075

merged 3 commits into from
Oct 23, 2017

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Oct 23, 2017 •
edited
Loading

What is the purpose of this pull request?

task

Does your PR contain necessary tests?

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

  • new tool method for arrays

close #1073

@mlewand mlewand requested a review from Comandeer October 23, 2017 11:06
Comandeer
Comandeer approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Comandeer Comandeer merged commit 5a4a46f into major Oct 23, 2017
@Comandeer Comandeer deleted the t/1073 branch October 23, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Comandeer Comandeer Comandeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New tool CKEDITOR.tools.array.every
2 participants
@msamsel @Comandeer