Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget plugin throws exception if included in editor build but not loaded #1287

Closed
mlewand opened this issue Nov 30, 2017 · 0 comments · Fixed by #1286
Closed

Widget plugin throws exception if included in editor build but not loaded #1287

mlewand opened this issue Nov 30, 2017 · 0 comments · Fixed by #1286
Labels
plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 30, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

You could simplify below steps by just opening https://codepen.io/mlewand/pen/qVQgmV

  1. Create a build that includes a widget plugin.
  2. Create an editor that excludes widget plugin (but the plugin is still inlined in the ckeditor.js).
  3. Open the page in a web browser.
  4. Open console.

Expected result

No exceptions are thrown.

Actual result

ckeditor.js:886 Uncaught TypeError: Cannot read property 'registered' of undefined
    at c.toAllowedContentRules (ckeditor.js:886)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.filter.allow (ckeditor.js:213)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.filter.allow (ckeditor.js:214)
    at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.filter.addFeature (ckeditor.js:218)
    at addFeature (ckeditor.js:265)
    at g (ckeditor.js:629)
    at b (ckeditor.js:628)
    at a (ckeditor.js:630)
    at a.<anonymous> (ckeditor.js:635)
    at a.c (ckeditor.js:11)

Other details

This originates from #1278 test that started to fail once we enabled widget plugin in 4.8.0 release.

The codepen I linked, hotlinks to 4.7.3 build for our websites, which bundles widget plugin.

  • Browser: Any
  • OS: Any
@mlewand mlewand added type:bug A bug. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. labels Nov 30, 2017
@f1ames f1ames mentioned this issue Nov 30, 2017
Merged
2 tasks
@mlewand mlewand added this to the Backlog milestone Nov 30, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 30, 2017
@f1ames f1ames mentioned this issue Nov 30, 2017
Open
@mlewand mlewand modified the milestones: Backlog, 4.8.0 Nov 30, 2017
@Comandeer Comandeer mentioned this issue Nov 30, 2017
Merged
mlewand added a commit that referenced this issue Nov 30, 2017
@mlewand
Merge pull request #1289 from ckeditor/changelog-1287
aaaf528 
Missing changelog entry for #1287 ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Add custom style handler only when loading widget plugin ckeditor/ckeditor4
1 participant
@mlewand