Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(molecule): incorrect fallback Bytes codec in codegen #737

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Aug 5, 2024

Description

This PR fixes a bug in lumos-molecule-codegen CLI, that generates incorrect code from vector Bytes <byte> schema

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit test

@homura homura requested a review from Keith-CY August 5, 2024 11:59
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Aug 5, 2024 0:02am

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (3cf82d9) to head (7843f5d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
- Coverage    87.24%   87.23%   -0.01%     
===========================================
  Files          133      133              
  Lines        25378    25375       -3     
  Branches      2751     2750       -1     
===========================================
- Hits         22141    22136       -5     
- Misses        3197     3201       +4     
+ Partials        40       38       -2     
Files Coverage Δ
packages/molecule/src/codegen.ts 96.72% <100.00%> (-0.03%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf82d9...7843f5d. Read the comment docs.

@homura homura changed the title fix(molecule): directly output generated code to console fix(molecule): incorrect fallback Bytes codec in codegen Aug 5, 2024
@homura homura merged commit 66bbbfd into develop Aug 5, 2024
9 checks passed
@homura homura deleted the molecule-codegen-fallback-bytes branch August 5, 2024 13:24
@github-actions github-actions bot mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants