Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: replace Buffer with Uint8Array #713

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

twhy
Copy link
Contributor

@twhy twhy commented Jun 12, 2024

Description

This PR replaces Buffer with Uint8Array completely in Lumos packages.
scrypt-js which requires Buffer has been replaced by @noble/hashes/scrypt.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Unit Tests

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 13, 2024 2:03am

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 90.78947% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (d13f880) to head (2f94343).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           browser     #713   +/-   ##
========================================
  Coverage    87.11%   87.11%           
========================================
  Files          132      132           
  Lines        25233    25249   +16     
  Branches      2736     2736           
========================================
+ Hits         21982    21996   +14     
- Misses        3210     3212    +2     
  Partials        41       41           
Files Coverage Δ
packages/base/src/utils.ts 84.11% <100.00%> (ø)
packages/common-scripts/src/common.ts 89.55% <100.00%> (ø)
packages/debugger/src/executor.ts 97.95% <100.00%> (+0.02%) ⬆️
packages/hd/src/extended_key.ts 97.74% <100.00%> (+0.05%) ⬆️
packages/hd/src/key.ts 96.84% <100.00%> (+0.10%) ⬆️
packages/hd/src/keychain.ts 100.00% <100.00%> (ø)
packages/hd/src/keystore.ts 92.08% <100.00%> (-0.13%) ⬇️
packages/base/src/values.ts 84.28% <0.00%> (ø)
packages/hd/src/mnemonic/index.ts 39.42% <45.83%> (-0.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13f880...2f94343. Read the comment docs.

@twhy twhy requested review from homura and Keith-CY June 12, 2024 03:16
@homura homura merged commit fec185f into browser Jun 13, 2024
9 checks passed
@twhy twhy deleted the replace-Buffer-with-Uint8Array branch June 13, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants