Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove isDeepEqual function #711

Merged
merged 2 commits into from
Jun 12, 2024
Merged

BREAKING CHANGE: remove isDeepEqual function #711

merged 2 commits into from
Jun 12, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Jun 11, 2024

Description

This PR removes the function isDeepEqual since it is not used in other packages to reduce the package size

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@homura homura requested review from Keith-CY and twhy June 11, 2024 09:21
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 11, 2024 9:23am

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (8d11c75) to head (ec4bb6c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #711      +/-   ##
===========================================
- Coverage    85.67%   84.69%   -0.99%     
===========================================
  Files          131      131              
  Lines        25247    25241       -6     
  Branches      2663     2593      -70     
===========================================
- Hits         21631    21377     -254     
- Misses        3576     3828     +252     
+ Partials        40       36       -4     
Files Coverage Δ
packages/base/src/utils.ts 83.76% <ø> (-0.36%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d11c75...ec4bb6c. Read the comment docs.

@Keith-CY
Copy link
Member

It's not a breaking change because isDeepEqual has not been exported to users.

@Keith-CY
Copy link
Member

It's not a breaking change because isDeepEqual has not been exported to users.

Fix myself, it's been exported

@homura homura merged commit b370502 into develop Jun 12, 2024
9 checks passed
@homura homura deleted the rm-unused-lib branch June 12, 2024 03:05
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants