-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace node crypto methods with noble methods #709
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## browser #709 +/- ##
===========================================
+ Coverage 87.06% 87.12% +0.05%
===========================================
Files 132 132
Lines 25246 25227 -19
Branches 2738 2737 -1
===========================================
- Hits 21981 21979 -2
+ Misses 3225 3208 -17
Partials 40 40
Continue to review full report in Codecov by Sentry.
|
Description
This PR replaces Node crypto
createHash
,createHmac
,createCipheriv
... with@noble/hashes
and@noble/ciphers
.Once merged, there will be no
import {} from 'crypto'
orimport {} from 'node:crypto'
in Lumos packages.Type of change
How Has This Been Tested?
Unit Tests