Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common-scripts): deprecate bitcoin p2sh in omnilock #682

Merged
merged 2 commits into from
May 11, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented May 11, 2024

Description

Fixes #680

This PR

  • deprecated the API createOmnilockScript, and a new API createSimplePublicKeyBasedOmnilockScript to replace it
  • supported create an Omnilock from a BTC testnet address

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview May 11, 2024 2:18am

@homura homura requested a review from Keith-CY May 11, 2024 01:56
@homura homura merged commit ed7c2fa into develop May 11, 2024
7 checks passed
@homura homura deleted the deprecate-btc-p2sh branch May 11, 2024 02:20
@github-actions github-actions bot mentioned this pull request May 11, 2024
homura added a commit that referenced this pull request Jun 6, 2024
Keith-CY added a commit that referenced this pull request Jun 6, 2024
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depreacte the support of Omnilock Bitcoin authentication's P2SH address
2 participants