-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support joyid #659
feat: support joyid #659
Conversation
Co-authored-by: Chen Yu <[email protected]> Signed-off-by: homura <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #659 +/- ##
===========================================
+ Coverage 84.30% 87.36% +3.06%
===========================================
Files 121 124 +3
Lines 24574 24954 +380
Branches 2364 2570 +206
===========================================
+ Hits 20717 21801 +1084
+ Misses 3816 3105 -711
- Partials 41 48 +7
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
f593593
to
08e22ca
Compare
# Conflicts: # examples/pnpm-lock.yaml
CI failed |
the new ESLint rule |
Description
Resolve #640
This PR introduces a new package
@ckb-lumos/joyid
for singing, and collecting cells with the JoyID lock. However, due to some limitations of the JoyID lock, a transaction can only contains a JoyID lock, which means you CAN'T mix locks, such as the secp256k1-blake160 lock, in a transaction, even with another JoyID lock that has a differentlock.args
Type of change
How Has This Been Tested?